pyproject.toml: PEP 639 compatibility #209
Conversation
|
You may want to add |
|
The default value of |
|
Two 👍, just waiting on a review from someone with merge privileges... |
Signed-off-by: Adam J. Stewart <[email protected]>
Co-authored-by: Dimitri Papadopoulos Orfanos <[email protected]>
Co-authored-by: Dimitri Papadopoulos Orfanos <[email protected]>
adamjstewart
force-pushed
the
pyproject/license
branch
from
4df8450 to
d4ca023
Compare
| readme = "README.md" | ||
| license = { file = "LICENSE" } | ||
| license = "MIT-0 AND MIT" | ||
| license-files = ["LICENSE", "src/c/libffi_x86_x64/LICENSE"] |
There was a problem hiding this comment.
This adds the license for libffi_x86_64. Is this part of the wheel for all platform or just x86_64?
There was a problem hiding this comment.
At the moment, license-files cannot be configured dynamically, it must be the same for all platforms: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata. Whether or not the license for libffi should be included or excluded is another question.
There was a problem hiding this comment.
There are also from-source builds that will not bundle libffi at all.
There was a problem hiding this comment.
It's distributed with the source dist, isn't it? I would therefore argue the package should reference that licence.
4 participants
Reverts #199
Fixes #200
PEP 621 is superseded by PEP 639. The previous syntax is deprecated and will be removed in a future version of setuptools.
@Bluefissure @EpicWink @mattip